Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

[Felix Zielcke]

Am Mittwoch, den 13.08.2008, 11:47 +0200 schrieb Marco Gerards:
> Felix Zielcke <address@hidden> writes:
> 
> > On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote:
> >> >         * kern/err.c [GRUB_UTIL]: Include <stdio.h>.
> >
> >> Please don't do this.  Why do you want this?
> >
> > It's needed for fprintf, and fprintf is only useful for GRUB_UTIL.
> 
> I understood that.  With this I meant "changing the kernel for GRUB_UTIL" :)
> 

I just did it first that way, because we need a simple and small patch
for lenny (i.e. debian-release)

If I do it like you prefer duplicating it in util/misc.c then I need to
remove the static from `int grub_error_stack_assert;' and having it
prefixed with extern on grub/err.h

Yes this change is no problem, grub-probe now compiles fine
But grub-mkimage not:

grub_mkimage-util_misc.o: In function `grub_print_error':
/home/fz/grub/grub2.svn/util/misc.c:315: undefined reference to `grub_error_pop'
/home/fz/grub/grub2.svn/util/misc.c:312: undefined reference to `grub_errno'
/home/fz/grub/grub2.svn/util/misc.c:313: undefined reference to `grub_errmsg'
/home/fz/grub/grub2.svn/util/misc.c:313: undefined reference to `grub_printf'
/home/fz/grub/grub2.svn/util/misc.c:315: undefined reference to `grub_error_pop'
/home/fz/grub/grub2.svn/util/misc.c:320: undefined reference to `grub_printf'
collect2: ld returned 1 exit status
make: *** [grub-mkimage] Error 1

So for me it seems kern/err.c has to be either doubled for the utils or,
just like I did first, with just changing 2 grub_printf to fprintf for
GRUB_UTIL