[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gfxterm: check elements' properties and hadle errors.

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] gfxterm: check elements' properties and hadle errors.
Date: Thu, 07 Mar 2013 08:31:00 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12

On 04.03.2013 12:27, Vladimir Testov wrote:

> +  else
> +    {
> +      return GRUB_ERR_IO;
> +    }

This is not a correct error handling. You should never return an error
without calling grub_error. Also in all these contexts you handle the
cases of unknown property name. I don't feel like refusing to load a
theme because of unknown property is a good idea. This would i.a.
exclude older GRUB versions for newer themes even if property in
question is minor in meaning. Compare this to a browser refusing to show
a page because of unknown tag attribute. Also GRUB_ERR_IO hardly
describes a condition of unknown property.

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]