[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Merging ‘wip-newt-installer’ in master?

From: Mathieu Othacehe
Subject: Re: Merging ‘wip-newt-installer’ in master?
Date: Thu, 22 Nov 2018 23:57:38 +0900
User-agent: mu4e 1.0; emacs 26.1

Hey Ludo,

> If you add it to /etc/environment (through
> ‘session-environment-service-type’) it should be fine no?

LANG is already part of /etc/environment variables which are loaded by
the login program which is PAM aware. The installer isn't PAM aware and
it replaces the login program thus LANG is never loaded.

>   1. ./configure and (guix self) are adjusted to not build the
>      installer, at least by default.
>   2. The “old” installation method remains prominently available, either
>      by making it clear people can use ctrl-alt-f2 & co. to switch to a
>      terminal, and maybe adding a message on the welcome page stating
>      that the installer is “beta” or something.
>   3. The manual is updated to at least mention the new installer, maybe
>      not in detail.
> How does that sound?

I agree it would be great :), I'm currently focusing on parted support
but, I'll shift to the 3 points you described above so that it can be
merged on time.

> It seems to me that it’s OK to push it quickly because it looks pretty
> good already and if it happens to be buggy, people can always use the
> old method.

Sure, it is a big addition to the codebase, so its important people can
start debugging it as soon as possible.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]