guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#61255] [PATCH 2/5] gexp: computed-file: Honor %guile-for-build.


From: Ludovic Courtès
Subject: [bug#61255] [PATCH 2/5] gexp: computed-file: Honor %guile-for-build.
Date: Sat, 04 Feb 2023 02:11:23 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Hello!

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> * guix/gexp.scm (computed-file): Set the default value of the #:guile argument
> to that of the %guile-for-build parameter.

[...]

>  (define* (computed-file name gexp
> -                        #:key guile (local-build? #t) (options '()))
> +                        #:key (guile (%guile-for-build))
> +                        (local-build? #t) (options '()))

I think that would lead ‘computed-file’ to pick (%guile-for-build) at
the wrong time (time of call instead of time of lowering).

Commit ab25eb7caaf5571cc9f8d6397a1eae127d7e29d1 made it #f such that
‘gexp->derivation’ gets to resolve it at the “right” time.

Does that make sense?  But perhaps this approach isn’t suitable in the
use case you’re looking at?

HTH,
Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]