guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#61255] [PATCH 0/5] Add support for the RPM format to "guix pack"


From: Ludovic Courtès
Subject: [bug#61255] [PATCH 0/5] Add support for the RPM format to "guix pack"
Date: Thu, 23 Feb 2023 16:47:20 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi,
>>
>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>>
>>> * tests/pack.scm: Fix indentation.
>>
>> [...]
>>
>>>         (check   (gexp->derivation
>>> -                 "check-tarball"
>>> -                 (with-imported-modules '((guix build utils))
>>
>> [...]
>>
>>> +                    "check-tarball"
>>> +                  (with-imported-modules '((guix build utils))
>>
>> I’m not convinced by the indentation rule for ‘gexp->derivation’ added
>> in 82daab42811a2e3c7684ebdf12af75ff0fa67b99: there’s no reason to treat
>> ‘gexp->derivation’ differently from other procedures.
>
> The benefit I saw was that writing
>
>  (gexp->derivation the-name
>   #~(begin
>      (the
>        (multi-line
>         (gexp)))))

I understand, but you know, it’s best to avoid unilaterally changing
established conventions.  :-)

If and when there’s consensus about this change, (guix read-print)
should be updated.

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]