[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bookmarks in EWW

From: Stefan Monnier
Subject: Re: Bookmarks in EWW
Date: Wed, 25 Mar 2020 10:06:57 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> Ok, I've thrown something together (draft!) and tested quickly:


> +  ;; Emacs bookmarks support
> +  (defvar bookmark-make-record-function)
> +  (setq-local bookmark-make-record-function #'eww-bookmark-make-record)

No need for the `defvar` here.

> Does it make sense that these bookmarks save a text part?  Surely makes
> sense for some cases, e.g. locally saved documentation in html, but
> makes not much sense for e.g. newspaper sites.

As you say, it's useful for pages which don't change (or not much), and
it should be harmless for those pages that change too frequently.

> Do I need to declare `bookmark-make-record-function' as special when
> setting with `setq-local' (that's what doc-view does)?

No.  buffer-localness is a concept that only applies to dynamically
scoped variables anyway, so if you need it it's a sign that we should
improve something somewhere.

> Do I have to add a NEWS entry?

I think it deserves a mention, yes.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]