[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Please test gsasl 0.2.29 release candidate!

From: Adam Strzelecki
Subject: Re: Please test gsasl 0.2.29 release candidate!
Date: Sat, 11 Oct 2008 18:05:53 +0200


Please don't release 0.2.29 yet. I have serious concerns about sanity of latest changes.

First of all MinGW has auto-export functionality, but it should be compatible with Windows __declspec(dllexport). So I wonder what was the errors while building in MinGW? However if we want to limit GSASL_API to MS Visual C++ only, please bring back old GSASL_API block and just change:

# if defined(_WIN32) && !defined(GSASL_STATIC)


# if defined(_MSC_VER) && !defined(GSASL_STATIC)

but don't define GSASL_API inside of the VC project. Latest will probably beak VC projects relaing on libgsasl, since GSASL_API neither MSVC (which isn't standard macro) is not defined there (_MSC_VER is standard macro defined by Microsoft compiler). Also GSASL_EXPORTS & GSASL_EXPORTS matches Microsoft convention for building MSVC libraries (this is how M$ marks 99% of its projects and this is how Visual Studio macros create new library projects), having GSASL_API defined in project is against this. This convention isn't maybe wise & pretty but this is what MSVC programmer are used to.

I'm fine with rest of the changes to drop Perl dependency. I remember you were asking for having this Perl script in gsasl as is was done in libidn though, and now we drop it back :>

Best regards,
Adam Strzelecki

reply via email to

[Prev in Thread] Current Thread [Next in Thread]