Re: [libmicrohttpd] [PATCH] Fix test_upgrade/test_upgrade_tls running in parallel

[Evgeny Grin]

Hi Tim,

Thanks for details.
I'll fix this case.

However, it is not advisable to use any -Werror= flags for configure, as
it may break some tests.
For example, if you will use -Werror=extra-semi clang flag then you will
break most of compile and link tests.
I'd recommend you to run configure without any -Werror flags, but
redefine CGLAGS with -Werror parameters for make invocation.

-- 
Wishes,
Evgeny

29.05.2019 12:45, Tim Rühsen wrote:
> On 5/28/19 9:07 PM, Evgeny Grin wrote:
>> On which system did you test it?
>> Looks like MHD_FEATURE_AUTODETECT_BIND_PORT is not available on you OS,
>> which is pretty strange as it should works on all modern platforms.
>>
> MHD_config.h:
> /* Define if you have usable `getsockname' function. */
> /* #undef MHD_USE_GETSOCKNAME */
>
> config.log:
> configure:18603: checking whether getsockname is declared
> configure:18603: result: yes
> configure:18629: checking for getsockname
> configure:18629: result: yes
> configure:18635: checking whether getsockname() is usable
> ...
> conftest.c: In function 'main':
> conftest.c:165:3: error: implicit declaration of function 'close'
> [-Werror=implicit-function-declaration]
>   165 |   close (sckt);
>       |   ^~~~~
> conftest.c:165:3: warning: nested extern declaration of 'close'
> [-Wnested-externs]
> cc1: some warnings being treated as errors
> configure:18730: $? = 1
> configure: program exited with status 1
> configure:18742: result: no
>
>
> I am using
> $ gcc-9 --version
> gcc-9 (Debian 9.1.0-1) 9.1.0
>
> with a lot of warning flags - though I don't use -Werror explicitly.
>
> It's your configure.ac code that doesn't play well here.
> Why are you not just using "AC_CHECK_FUNCS([getsockname])" ? Or use
> gnulib as portability layer ?
>
> Regards, Tim
>

signature.asc
Description: OpenPGP digital signature