libmicrohttpd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [libmicrohttpd] [PATCH] Fix test_upgrade/test_upgrade_tls running in


From: Tim Rühsen
Subject: Re: [libmicrohttpd] [PATCH] Fix test_upgrade/test_upgrade_tls running in parallel
Date: Thu, 30 May 2019 15:45:51 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0

Hi Evgeny,

On 30.05.19 13:50, Evgeny Grin wrote:
> Hi Tim,
> 
> Thanks for details.
> I'll fix this case.

Thank you !

> 
> However, it is not advisable to use any -Werror= flags for configure, as
> it may break some tests.
> For example, if you will use -Werror=extra-semi clang flag then you will
> break most of compile and link tests.
> I'd recommend you to run configure without any -Werror flags, but
> redefine CGLAGS with -Werror parameters for make invocation.
> 

My CFLAGS are

ac_configure_args =  'CFLAGS=-g -Og -Wall -Wextra -Wall -Wextra
-Wformat=2 -Walloc-zero -Walloca -Wbad-function-cast -Wcomments
-Wdate-time -Wdouble-promotion -Wduplicated-branches -Wduplicated-cond
-Werror-implicit-function-declaration -Wfloat-conversion -Wfloat-equal
-Wformat -Wformat-signedness -Wformat-truncation -Winit-self
-Winvalid-pch -Wjump-misses-init -Wlogical-op -Wmissing-declarations
-Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-prototypes
-Wmultichar -Wnested-externs -Wnormalized -Wold-style-definition
-Woverlength-strings -Wpedantic -Wpointer-arith -Wredundant-decls
-Wscalar-storage-order -Wshift-overflow -Wstrict-prototypes
-Wstringop-overflow -Wswitch-default -Wswitch-enum -Wundef
-Wunused-const-variable -Wvariadic-macros -Wwrite-strings
-Warray-bounds=2 -Wnormalized=nfc -Wshift-overflow=2
-Wunused-const-variable=2 -Wformat-overflow=2 -Wformat-truncation=1
-Wstringop-overflow=2 -fdiagnostics-color=always -Wno-cast-function-type'

So there is this -Werror-implicit-function-declaration. The CFLAGS are
automatically generated by using 'gcc -Q --help=warnings,C' and some
scripting within a m4 file. This command lists
-Werror-implicit-function-declaration for gcc-4.6 and higher. I wonder
if this is a gcc bug that I run into - since only warnings have been
requested.

Regards, Tim

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]