[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Patch for new harmonic glyph

From: Maximilian Albert
Subject: Patch for new harmonic glyph
Date: Thu, 25 Jan 2007 15:56:02 +0100
User-agent: IceDove (X11/20061220)

Han-Wen Nienhuys wrote:

>> I also added a glyph called "s1harmonic" which [...] in a way "closes
>> the gap" between "s0" and "s2". [...] Agree?
> No, this should be handled by the code in output-lib. That code's sole purpose
> is to fill all the gaps in the different styles.

Alright, so I removed "s1harmonic" from mf/ again but
left the two new styles as they are. If you feel comfortable with it
this way (otherwise please do not hesitate to make further suggestions)
it might be good to update the docs, too (probably adding two sample
bars to in the regression tests would suffice). If
you wish I can try to do that later on.

> I'd like to integrate your patch. However, could you post a patch made with
> GIT to the list, so I can apply without having to invent a commit  message
> and C&P-ing your name & email? 

Sure. And sorry, I could have thought of that in advance. Please find
the git patch attached.

Thanks and cheers
From 0c7eb62cca9c20cb8406fe454b4ec74e08043143 Mon Sep 17 00:00:00 2001
From: Maximilian Albert <address@hidden>
Date: Thu, 25 Jan 2007 14:57:56 +0100
Subject: [PATCH] New glyph (black diamond) and two harmonic-like notehead 
styles using it.

 mf/ |    7 +++++++
 scm/output-lib.scm   |    3 +++
 2 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/mf/ b/mf/
index da64dbe..551e3e3 100644
--- a/mf/
+++ b/mf/
@@ -192,6 +192,13 @@ fet_beginchar("Harmonic notehead (Neo-mensural open)",
        charwy := 0;
+fet_beginchar("Harmonic notehead (Neo-mensural black)",
+             "s2harmonic")
+       draw_neomensural_black_head (1.3 staff_space#, 1.3 noteheight#);
+       charwx := head_width#;
+       charwy := 0;
 fet_beginchar("Neo-mensural semibrevis head","s0neomensural")
       draw_neomensural_open_head (staff_space#, noteheight#);
diff --git a/scm/output-lib.scm b/scm/output-lib.scm
index f66a78b..11f427b 100644
--- a/scm/output-lib.scm
+++ b/scm/output-lib.scm
@@ -168,6 +168,9 @@
       ;; statement.  -- jr
       ((xcircle) "2xcircle")
       ((harmonic) "0harmonic")
+      ((harmonic-black) "2harmonic")
+      ((harmonic-mixed) (if (<= log 1) "0harmonic"
+                                       "2harmonic"))
        ;; Oops, I actually would not call this "baroque", but, for
        ;; backwards compatibility to 1.4, this is supposed to take

reply via email to

[Prev in Thread] Current Thread [Next in Thread]