lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

showFirstLength


From: hanwenn
Subject: showFirstLength
Date: Mon, 20 Oct 2008 05:17:00 -0700

Reviewers: Valentin Villenave,


http://codereview.appspot.com/7317/diff/1/4
File scm/music-functions.scm (right):

http://codereview.appspot.com/7317/diff/1/4#newcode827
Line 827: "set skipTypesetting, make SkipMusic of the given MUS length,
update doc string mus suggests music argument, but you are passing a
moment.

http://codereview.appspot.com/7317/diff/1/4#newcode836
Line 836: (ly:moment-main-denominator mus)))
this looks like a good candidate for a function

  make-duration-of-music-length

http://codereview.appspot.com/7317/diff/1/4#newcode841
Line 841: "unset skipTypesetting if set, make SkipMusic of the given MUS
length,
update doc string: you're always unsetting

http://codereview.appspot.com/7317/diff/1/4#newcode843
Line 843: (make-sequential-music
fix indent ; use emacs indent-region

http://codereview.appspot.com/7317/diff/1/4#newcode867
Line 867: ((show-last  (ly:parser-lookup parser 'showLastLength))
one space after var name.

http://codereview.appspot.com/7317/diff/1/4#newcode884
Line 884: 'symbol 'whichBar)))
you may want to do this in 'Timing context.

Description:
showFirstLength




* new showFirstLength feature
This commit implements a showFirstLength property, that does
the opposite of showLastLength (both properties may be set,
in this case the beginning and the end of the piece are printed,
with a double barline as a separator).

When only showFirstLength is set, the 'length property is
overriden (except if already shorter than the specified first
length) and therefore the compilation will be much faster.

This new feature may be very convenient, e.g. to print the
index of a book containing only the beginning of each \score.

Please review this at http://codereview.appspot.com/7317

Affected files:
  A input/regression/skiptypesetting-show-last-or-first.ly
  M input/regression/skiptypesetting-show-last.ly
  M scm/music-functions.scm






reply via email to

[Prev in Thread] Current Thread [Next in Thread]