[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add tab-tie-follow-engraver (issue2723043)

From: Carl . D . Sorensen
Subject: Re: Add tab-tie-follow-engraver (issue2723043)
Date: Fri, 03 Dec 2010 16:32:07 +0000

Thanks for the feedback.  I've responded to the comments and posted a
new patch set.
File lily/ (left):
lily/ "HarmonicParenthesesItem ",
On 2010/11/28 22:24:05, Neil Puttock wrote:
This is never created, even for \tabFullNotation.

Deleting the engraver solved this issue
File lily/ (right):
lily/ victim->set_property ("style",
ly_symbol2scm ("harmonic"));
On 2010/11/28 22:24:05, Neil Puttock wrote:
This makes it difficult for users to tweak the appearance of the
brackets, though if you still think it's a price worth paying, you
might as well
junk the engraver and read 'articulations directly inside the notehead

I junked the engraver and added properties to the tab-note-head 'details
for cautionary and harmonic brackets.
File scm/define-grob-properties.scm (right):
scm/define-grob-properties.scm:965: (display-cautionary ,boolean?
"Display as cautionary.")

On 2010/11/28 22:24:05, Neil Puttock wrote:
Needs a more descriptive docstring.

Tried to make it more descriptive, but I didn't want it to be limited to
File scm/tablature.scm (right):
scm/tablature.scm:297: (whiteout (ly:grob-property grob 'whiteout #t))
On 2010/11/28 22:24:05, Neil Puttock wrote:
If 'whiteout is set, it's applied to the final stencil in

Removed it from the callback
scm/tablature.scm:321: (centered-stencil output-grob)))
On 2010/11/28 22:24:05, Neil Puttock wrote:
This has a nasty side-effect: it centres the noteheads on the
shifting them to the left of heads in other staves.

Added an offset to get the column centered one character-width to the
right of the paper column.  I think it's even better than it used to be.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]