lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adds beam collision avoidance to auto beaming (issue4290069)


From: Colin Campbell
Subject: Re: Adds beam collision avoidance to auto beaming (issue4290069)
Date: Tue, 29 Mar 2011 20:12:35 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8

On 11-03-29 04:54 PM, address@hidden wrote:
On Mar 28, 2011, at 6:39 PM, address@hidden wrote:

Looks much more readable, thanks!


http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc
File lily/beam-collision-engraver.cc (right):

http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc#newcode59
lily/beam-collision-engraver.cc:59: // Start conisdering grobs at the
first grob whose end falls at or after the beam's beginning.
typo: conisdering

http://codereview.appspot.com/4290069/
Can somebody please test this patch out on a few thorny keyboard pieces before 
I push it?  It will make beam collision kick in on all beams, and I want to 
make sure that I don't run into the same issue I did w/ accidentals.  I would 
do it myself, but I am not in possession of anything that could really test 
this to the max.

Cheers,
MS



If you point me toward a few thorny keyboard pieces, I can run some tests for you, Mike.

Colin

--
The test of our progress is not whether we add more to the abundance
of those who have much, it is whether we provide enough for those who
have too little.
-Franklin D. Roosevelt, 32nd US President (1882-1945)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]