|
| From: | hanwenn |
| Subject: | Re: Adds beam collision avoidance to auto beaming (issue4290069) |
| Date: | Wed, 30 Mar 2011 04:30:22 +0000 |
lgtm http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc#newcode64 lily/beam-collision-engraver.cc:64: for (vsize j = start; covered_grobs_[j]->spanned_rank_interval ()[LEFT] <= beams_[i]->spanned_rank_interval ()[RIGHT]; j++) you migth want to store beam[i]->spanned_rank_interval() in a local variable to improve readability. http://codereview.appspot.com/4290069/
| [Prev in Thread] | Current Thread | [Next in Thread] |