|
From: | n . puttock |
Subject: | Re: Fix calculation of vertical offset when 'staff-padding is set (issue4489042) |
Date: | Wed, 11 May 2011 18:28:08 +0000 |
LGTM. http://codereview.appspot.com/4489042/diff/1/input/regression/clef-octavation.ly File input/regression/clef-octavation.ly (right): http://codereview.appspot.com/4489042/diff/1/input/regression/clef-octavation.ly#newcode3 input/regression/clef-octavation.ly:3: \header{ \header { http://codereview.appspot.com/4489042/diff/1/input/regression/clef-octavation.ly#newcode5 input/regression/clef-octavation.ly:5: texidoc=" Octavate symbols should be correctly positioned close to texidoc = "Octavate http://codereview.appspot.com/4489042/diff/1/input/regression/clef-octavation.ly#newcode11 input/regression/clef-octavation.ly:11: \new Staff { \clef "G^8" g''1 } indent http://codereview.appspot.com/4489042/diff/1/input/regression/clef-octavation.ly#newcode18 input/regression/clef-octavation.ly:18: \layout { ragged-right = ##t } remove http://codereview.appspot.com/4489042/diff/1/lily/side-position-interface.cc File lily/side-position-interface.cc (right): http://codereview.appspot.com/4489042/diff/1/lily/side-position-interface.cc#newcode280 lily/side-position-interface.cc:280: Real diff = dir * staff_extent[dir] + staff_padding add parentheses to enforce indent http://codereview.appspot.com/4489042/
[Prev in Thread] | Current Thread | [Next in Thread] |