[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix calculation of vertical offset when 'staff-padding is set (issue
From: |
Trevor Daniels |
Subject: |
Re: Fix calculation of vertical offset when 'staff-padding is set (issue4489042) |
Date: |
Thu, 12 May 2011 17:16:22 +0100 |
Neil wrote Wednesday, May 11, 2011 7:28 PM
LGTM.
Thanks! I'll push after a couple of days if there are no more
comments.
http://codereview.appspot.com/4489042/diff/1/input/regression/clef-octavation.ly#newcode3
input/regression/clef-octavation.ly:3: \header{
\header {
Done
http://codereview.appspot.com/4489042/diff/1/input/regression/clef-octavation.ly#newcode5
input/regression/clef-octavation.ly:5: texidoc=" Octavate symbols
should
be correctly positioned close to
texidoc = "Octavate
Done
http://codereview.appspot.com/4489042/diff/1/input/regression/clef-octavation.ly#newcode11
input/regression/clef-octavation.ly:11: \new Staff { \clef "G^8"
g''1 }
indent
Done
http://codereview.appspot.com/4489042/diff/1/input/regression/clef-octavation.ly#newcode18
input/regression/clef-octavation.ly:18: \layout { ragged-right =
##t }
remove
Done
http://codereview.appspot.com/4489042/diff/1/lily/side-position-interface.cc#newcode280
lily/side-position-interface.cc:280: Real diff = dir *
staff_extent[dir]
+ staff_padding
add parentheses to enforce indent
Done. Neat idea!
http://codereview.appspot.com/4489042/
Trevor