[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
From: |
Phil Holmes |
Subject: |
Re: Rewrite regtest mozart-hrn-3.ly (issue4811066) |
Date: |
Mon, 8 Aug 2011 16:45:49 +0100 |
Woh. There's an error - \url isn't part of Lilypond syntax! I'd corrected
this to GP, but here's a corrected patch.
--
Phil Holmes
----- Original Message -----
From: "James Lowe" <address@hidden>
To: "Phil Holmes" <address@hidden>; <address@hidden>;
<address@hidden>; <address@hidden>; <address@hidden>;
<address@hidden>; <address@hidden>
Sent: Monday, August 08, 2011 4:13 PM
Subject: RE: Rewrite regtest mozart-hrn-3.ly (issue4811066)
I'll push it.
james
)-----Original Message-----
)From: address@hidden
)[mailto:address@hidden On
)Behalf Of Phil Holmes
)Sent: 08 August 2011 15:54
)To: address@hidden; address@hidden;
)address@hidden; address@hidden; address@hidden;
)address@hidden; address@hidden
)Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
)
)----- Original Message -----
)From: <address@hidden>
)To: <address@hidden>; <address@hidden>;
)<address@hidden>; <address@hidden>
)Cc: <address@hidden>; <address@hidden>
)Sent: Sunday, August 07, 2011 11:42 PM
)Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
)
)
)> LGTM. My comment is a tiny nitpick; I don't think it needs to hold up
)> pushing this.
)>
)>
)>
)http://codereview.appspot.com/4811066/diff/8003/input/regression/mo
)zar
)> t-hrn-3.ly File input/regression/mozart-hrn-3.ly (right):
)>
)>
)http://codereview.appspot.com/4811066/diff/8003/input/regression/mo
)zar
)> t-hrn-3.ly#newcode27
)> input/regression/mozart-hrn-3.ly:27: \typewriter {
)> "http://mutopiaproject.org/" } this would be slightly nicer if you
)> used \url instead of \typewriter.
)> That would use that typeface, but would also produce a clickable link.
)>
)> http://codereview.appspot.com/4811066/
)
)Nitpick changed - I've kept typewriter for the look, but added url. Patch
)attached. Please push.
)
)--
)Phil Holmes
0001-Update-regtest-morart-hrn.patch
Description: Binary data
- Re: Rewrite regtest mozart-hrn-3.ly (issue4811066), (continued)
- Re: Rewrite regtest mozart-hrn-3.ly (issue4811066), percival . music . ca, 2011/08/02
- Re: Rewrite regtest mozart-hrn-3.ly (issue4811066), n . puttock, 2011/08/02
- Re: Rewrite regtest mozart-hrn-3.ly (issue4811066), PhilEHolmes, 2011/08/06
- Re: Rewrite regtest mozart-hrn-3.ly (issue4811066), n . puttock, 2011/08/06
- Re: Rewrite regtest mozart-hrn-3.ly (issue4811066), percival . music . ca, 2011/08/07
- Re: Rewrite regtest mozart-hrn-3.ly (issue4811066), Phil Holmes, 2011/08/08
- RE: Rewrite regtest mozart-hrn-3.ly (issue4811066), James Lowe, 2011/08/08
- RE: Rewrite regtest mozart-hrn-3.ly (issue4811066), James Lowe, 2011/08/08
- Re: Rewrite regtest mozart-hrn-3.ly (issue4811066),
Phil Holmes <=
- RE: Rewrite regtest mozart-hrn-3.ly (issue4811066), James Lowe, 2011/08/08
- RE: Rewrite regtest mozart-hrn-3.ly (issue4811066), James Lowe, 2011/08/08
- Re: Rewrite regtest mozart-hrn-3.ly (issue4811066), Phil Holmes, 2011/08/08
- RE: Rewrite regtest mozart-hrn-3.ly (issue4811066), James Lowe, 2011/08/08
- Re: Rewrite regtest mozart-hrn-3.ly (issue4811066), Graham Percival, 2011/08/08
- Re: Rewrite regtest mozart-hrn-3.ly (issue4811066), Phil Holmes, 2011/08/09
- Re: Rewrite regtest mozart-hrn-3.ly (issue4811066), Neil Puttock, 2011/08/09
- Re: Rewrite regtest mozart-hrn-3.ly (issue4811066), Graham Percival, 2011/08/08