[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Final redirection of texi output (issue 5650064)
From: |
julien . rioux |
Subject: |
Re: Final redirection of texi output (issue 5650064) |
Date: |
Mon, 13 Feb 2012 13:56:09 +0000 |
Looks good, I just have a few suggestions to avoid clashing log file
names and I wonder how this part of GOP 9 might be implemented down the
road:
"All other logfiles will go in the @file{build/logfiles/} directory."
http://codereview.appspot.com/5650064/diff/5003/Documentation/GNUmakefile
File Documentation/GNUmakefile (right):
http://codereview.appspot.com/5650064/diff/5003/Documentation/GNUmakefile#newcode234
Documentation/GNUmakefile:234: $(buildscript-dir)/run-and-check
"$(MAKEINFO) -I$(src-dir) -I$(outdir) --output=$(dir $@) --docbook $<"
"$*.makeinfo.log"
We might need .makeinfoxml.log here, or something similar, to
distinguish the log files.
http://codereview.appspot.com/5650064/diff/5003/Documentation/GNUmakefile#newcode238
Documentation/GNUmakefile:238: $(buildscript-dir)/run-and-check
"$(MAKEINFO) -I$(src-dir) -I$(outdir) --output=$(dir $@) --docbook $<"
"$*.makeinfo.log"
again, .makeinfoxml.log
http://codereview.appspot.com/5650064/diff/5003/make/doc-i18n-root-rules.make
File make/doc-i18n-root-rules.make (right):
http://codereview.appspot.com/5650064/diff/5003/make/doc-i18n-root-rules.make#newcode10
make/doc-i18n-root-rules.make:10: $(buildscript-dir)/run-and-check
"DEPTH=$(depth)/../ $(TEXI2HTML) $(TEXI2HTML_SPLIT) $(TEXI2HTML_FLAGS)
--output=$(outdir)/$* $<" "$*.splittexi.log"
I suggest adding $(ISOLANG) to the name of the log files generated from
this Makefile, eg:
$*.$(ISOLANG).splittexi.log
http://codereview.appspot.com/5650064/diff/5003/stepmake/stepmake/texinfo-rules.make
File stepmake/stepmake/texinfo-rules.make (right):
http://codereview.appspot.com/5650064/diff/5003/stepmake/stepmake/texinfo-rules.make#newcode75
stepmake/stepmake/texinfo-rules.make:75:
$(buildscript-dir)/run-and-check "$(MAKEINFO) -I$(src-dir) -I$(outdir)
--no-split --no-headers --output $@ $<" "$*.makeinfo.log"
.makeinfotxt.log
http://codereview.appspot.com/5650064/
- Re: Final redirection of texi output (issue 5650064), (continued)
Re: Final redirection of texi output (issue 5650064), PhilEHolmes, 2012/02/13
Re: Final redirection of texi output (issue 5650064),
julien . rioux <=
Re: Final redirection of texi output (issue 5650064), julien . rioux, 2012/02/15