Re: Doc: NR clarified \footnote command as a TextScript (issue 6137050)

[pkx166h]

New patch set uploaded


http://codereview.appspot.com/6137050/diff/8003/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/6137050/diff/8003/Documentation/notation/input.itely#newcode1044
Documentation/notation/input.itely:1044: Automatic footnotes take three
arguments; the @var{Layout Object} to be
On 2012/05/12 18:23:23, Keith wrote:
> maybe "Automatically-numbered footnotes"

This made me re-think the titling of both these sections, so I have
re-titled them to something more descriptive and adjusted the body text
accordingly.

http://codereview.appspot.com/6137050/diff/8003/Documentation/notation/input.itely#newcode1049
Documentation/notation/input.itely:1049: The @code{\footnote} command
comes immediately after the item being
On 2012/05/12 21:01:35, Keith wrote:
> "... comes after the note or rest associated with the item being
annotated"
> to be more accurate for the odd things like the breath mark.  And as
you show
> later, if you have dynamics and a slur on a sharped note, you can type
the
> \footnote for the sharp after \f( -- which might be convenient.

Done.

http://codereview.appspot.com/6137050/diff/8003/Documentation/notation/input.itely#newcode1069
Documentation/notation/input.itely:1069: >1
On 2012/05/12 21:01:35, Keith wrote:
> maybe bring the example for #'Accidental up here, too, where there is
more space
> in the typeset output ?

>      >1
>      \breathe
>      cis2
>      \footnote #'(0.5 . 0.5) #'BreathingSign \markup { Gasp}
>      \footnote #'(0.5 , 0.5) #'Accidental \markup { Chromatic }


Done. Thanks.

http://codereview.appspot.com/6137050/diff/8003/Documentation/notation/input.itely#newcode1076
Documentation/notation/input.itely:1076: higher up in the list.}
On 2012/05/12 18:23:23, Keith wrote:
> Do you mean that footnotes on the same chord are numbered and listed
in order
> the vertical positions of their indicators, G Eb C ?   If that is it,
you might
> want it in normal text rather than a warning.
> (I had to look up 'descendancy', so my problem might have just been my
English
> comprehension.)

Done.

http://codereview.appspot.com/6137050/diff/8003/Documentation/notation/input.itely#newcode1076
Documentation/notation/input.itely:1076: higher up in the list.}
On 2012/05/12 18:23:23, Keith wrote:
> Do you mean that footnotes on the same chord are numbered and listed
in order
> the vertical positions of their indicators, G Eb C ?

If it is a chord yes, but you can have multiple 'grobs' that are not in
chords but come at the same vertical position too. I am not sure now.
Mike's turn of phrase might have been ambiguous when giving me answers
to questions on footnotes when I was writing this up but he might have
meant the same 'moment' in this case, but I am not sure if this is

1. Correct technically
2. Same vertical position is, in this context, synonymous with same
'moment' on the staff or not.
3. If it is do we want to get into explaining 'moments' in this case?

> If that is it, you might
> want it in normal text rather than a warning.
> (I had to look up 'descendancy', so my problem might have just been my
English
> comprehension.)

I removed the @warning, and used a simpler phrase, that will also make
for easier translation in the other languages.

http://codereview.appspot.com/6137050/diff/8003/Documentation/notation/input.itely#newcode1128
Documentation/notation/input.itely:1128: Manual footnotes takes four
arguments; the @var{Layout Object} to be
On 2012/05/12 18:23:23, Keith wrote:
> maybe "Footnotes with manually-chosen indicators take"

I've changed this based on the new section heading.

> and in any case, "take"

Done. (and also in the automatically numbered section too)

http://codereview.appspot.com/6137050/diff/8003/Documentation/notation/input.itely#newcode1159
Documentation/notation/input.itely:1159: higher up in the list.}
On 2012/05/12 18:23:23, Keith wrote:
>  From experiment, it seems that, a set of footnotes on one chord are
listed at
> the bottom of the page according to the vertical order of their
indicators.  --
> which is quite nice.

I've changed this wording as per the automatically numbered section too.

http://codereview.appspot.com/6137050/diff/8003/Documentation/notation/input.itely#newcode1181
Documentation/notation/input.itely:1181:
On 2012/05/12 18:23:23, Keith wrote:
> Works for me to put here, \breathe

Done.

http://codereview.appspot.com/6137050/diff/8003/Documentation/notation/input.itely#newcode1185
Documentation/notation/input.itely:1185: \markup  { \bold 4. { This is a
stem } }
On 2012/05/12 18:23:23, Keith wrote:
> and then here
>      \footnote
>       \markup { \teeny \musicglyph #"rests.4" }
>           #'(-0.5 . 0.5) #'BreathingSign
>       \markup { \null }

> In rhythms were you usually see a breath mark, it is printed just
before the
> next note.

I guess I don't see that in my own music, I picked up a few random
scores and they all came at or on the bar line.

> Breathing just after two eight notes is a little odd

Hmm... you obviously don't play marching brass music ;)

> but it would
> take some re-arranging of the example to make it realistic, and maybe
not worth
> it.

Probably not. I could use another grob if people really objected.

http://codereview.appspot.com/6137050/diff/8003/Documentation/notation/input.itely#newcode1185
Documentation/notation/input.itely:1185: \markup  { \bold 4. { This is a
stem } }
On 2012/05/12 18:23:23, Keith wrote:
> and then here
>      \footnote
>       \markup { \teeny \musicglyph #"rests.4" }
>           #'(-0.5 . 0.5) #'BreathingSign
>       \markup { \null }

> In rhythms were you usually see a breath mark, it is printed just
before the
> next note.  Breathing just after two eight notes is a little odd, but
it would
> take some re-arranging of the example to make it realistic, and maybe
not worth
> it.

Done.

http://codereview.appspot.com/6137050/