[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 1320: Scheme bar line interface (issue 6305115)

From: k-ohara5a5a
Subject: Re: Issue 1320: Scheme bar line interface (issue 6305115)
Date: Fri, 20 Jul 2012 21:16:01 +0000

Works fine for me, but it will need updated to synchronize with the
patches soon-to-be-pushed to the C version.

Since the C code is getting bug-fixes and improvements at the same time
as you port to Scheme, you should incorporate the improved behavior into
your Scheme code as soon as you agree that it is correct.  When the
changed C code is pushed, you will need to rebase your patch, but the
state of code we are reviewing will not change so often.

Marks and bar-numbers above repeat bars now seem to align to the center
of the repeat bar including the dots, where before they aligned to just
the double bar portion. Probably the reference point of the stencil has

The other regtest changes look acceptable to me, and it seems to work
essentially as fast as the C code on real music.
File lily/ (left):
lily/ Bar_line::non_empty_barline (Grob *me)
Good to keep this in C.  It used to live in until the
fix to issue 915.  Later, if we want to remove the file completely, it
could go back there, later.
lily/ ADD_INTERFACE (Bar_line,
Would this make more sense in define-grob-interfaces.scm ?
It would become the largest docstring in that file, but I don't see any
problem with that.
File lily/ (right):
lily/ "Compare two grobs.")
"Does @var{a} lie above @var{b} on the page?"
File scm/bar-line.scm (right):
scm/bar-line.scm:67: (define-public (bar-line::non-empty-barline grob)
where do you use this?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]