[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: push patch for issue 2679

From: Graham Percival
Subject: Re: push patch for issue 2679
Date: Tue, 24 Jul 2012 17:34:00 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Jul 24, 2012 at 05:26:01PM +0100, Phil Holmes wrote:
> I'd be happy to push this, but would like a little advice.  If I
> go to Rietveld and download the raw patch set, it comes without
> proper email addresses and formatting.  This means to push stuff
> from Rietveld, I have to git apply the diff, then manually
> update the author (assuming I remember).  Is there a way of
> getting a formatted patch?

Don't apply things directly from Rietveld.  Due to the problems
that you discovered, we can only use it as a reviewing tool, not a
patch management tool.

David Nalesnik should send you the file he gets from
git format-patch, after he fixed all merge conflicts etc.

- Graham

reply via email to

[Prev in Thread] Current Thread [Next in Thread]