[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Issue 1650: merge multiple header specifications. (issue 6445053)

From: graham
Subject: Issue 1650: merge multiple header specifications. (issue 6445053)
Date: Mon, 30 Jul 2012 14:35:05 +0000

LGTM, and I really like the comments in the regtests.  In a few
instances they were slightly unclear, though.
File input/regression/ (right):
input/regression/ % This should NOT replace,
but amend the header:
I spent 30 seconds trying to figure out why you wanted the title to be
printed as
  "Title New Title"
before I realized I was misreading the comment.

Could the comment instead be:
  % This should not replace the entire header, but only replace the
'title' field of the previous header.  The subtitle should be unchanged.

similar change below.  Alternately, you could change the field names:
  \header{ title="don't print this title" subtitle="print subtitle" }
  \header{ title="print this title"}
... etc.  (with proper line-breaks because humans like using \n as a
separator even if lilypond doesn't distinguish between types of
File input/regression/ (right):
input/regression/ %% Do we have a
title, and is "New Subtitle" the subtitle?
please change to:
  % this should print "new subtitle".
rather than having a question.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]