Re: Allows minimum-length to work for end-of-line spanners. (issue 7453046)

[Janek Warchoł]

David,

On Wed, Apr 3, 2013 at 12:15 PM, David Kastrup <address@hidden> wrote:
> Janek Warchoł <address@hidden> writes:
>
>> Hmm.  What about doing something constructive, then?
>
>> There is one big "let's do things right" patch that needs review.
>> Despite a lot of effort spent by its author on writing a detailed
>> description to attract reviewers, only one person cared to review it:
>> codereview.appspot.com/7768043
>
> If you bothered to look, you'd have found that in spite of daring to
> take off a week of vacation from a year of LilyPond development,
> I committed about half a dozen fixes of problems and regressions that
> impeded getting to stable release quality while also running a batch of
> Patchy tests.  I apologize if I don't seem to have the time to review
> post-stable release material thoroughly.  There is also the question of
> preparing the EU proposal.
>
> So I apologize if I don't appear to have the time to be constructive.
> It definitely looks like I should call off the stable release for good
> as nobody else wants to get bothered with its consequences and it is not
> like I don't have enough other stuff on my hand.

I apologize for making it look like i blamed you for the situation.
This was not my intention; it's not your fault that issue 3239 was
reviewed by one person only.  You're not responsible for reviewing
everything, and i certainly don't demand that you review something
when you're on vacation (issue 3239 was up for review before your
vacation, but this still doesn't mean that you have any duty to review
it).

I was indeed quite surprised to see you being so active during last
week, to the point that i wasn't sure if i remembered the date of your
vacation correctly.

I also believe that you deserved your vacation, and i'm sorry that you
didn't have more vacations during this year.

My only intention in writing the previous message was to point out
that "doing things right" is hard and that even thoroughly described
patches don't get much reviews, which is discouraging (that's only
stating a fact, i'm not blaming anyone for this).

Janek

PS i'm not sure what you mean by "reviewing thoroughly".  I never
expect anyone to do more than read commit messages and Rietveld diffs
once; that's why i spend so much time on polishing commit messages.
If anything is unclear after this first reading, i expect everyone to
ask me, even if such questions may look silly.