lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (i


From: k-ohara5a5a
Subject: Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)
Date: Tue, 30 Apr 2013 03:10:52 +0000

The commit 'simplify stack-stencils' seems strange, and wrong in one
detail.
I suppose that stacking the stencils from start of list to end is a bit
simpler conceptually.  From my point-of-view as a non-programmer, and
certainly non-schemer, the new code is not simpler to understand.




https://codereview.appspot.com/8869044/diff/22012/scm/stencil.scm
File scm/stencil.scm (right):

https://codereview.appspot.com/8869044/diff/22012/scm/stencil.scm#newcode46
scm/stencil.scm:46: (lambda (tail head)
Usually, the head is fixed-length and the tail grows, so maybe
'accumulated_stencil' and 'next_stencil'

https://codereview.appspot.com/8869044/diff/22012/scm/stencil.scm#newcode56
scm/stencil.scm:56: (let loop ((head (car stils)) (rest (cdr stils)))
Somewhere you need to step through the list of 'padding', in order to do
what the old code did.

https://codereview.appspot.com/8869044/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]