[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: input/regression/scheme-text-spanner.ly: fix problem with constants
From: |
david . nalesnik |
Subject: |
Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044) |
Date: |
Thu, 25 Jul 2013 15:20:26 +0000 |
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly
File input/regression/scheme-text-spanner.ly (right):
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode117
input/regression/scheme-text-spanner.ly:117: (event-drul (cons '()
'())))
On 2013/07/23 12:31:25, dak wrote:
Frankly, just throw out the crap event-drul and current-event, and
instead use
event-start and event-stop instead of (car event-drul) and (cdr
event-drul).
current-event also is never set to anything except (car event-drul),
so you can
just replace it with event-start.
This whole file is a huge parade of bad code.
Done.
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode157
input/regression/scheme-text-spanner.ly:157: (set! event-drul (cons '()
'())))))
On 2013/07/23 13:05:47, david.nalesnik wrote:
On 2013/07/23 12:31:25, dak wrote:
> You could do (set-car! event-drul '())
> (set-cdr! event-drul '())
> instead in order to not create a new cons cell.
OK, will do.
Fixed using new variables.
https://codereview.appspot.com/11614044/
- Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044), dak, 2013/07/23
- Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044), david . nalesnik, 2013/07/23
- Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044), dak, 2013/07/23
- Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044), david . nalesnik, 2013/07/23
- Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044), dak, 2013/07/23
- Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044), david . nalesnik, 2013/07/23
- Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044), dak, 2013/07/23
- Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044), david . nalesnik, 2013/07/23
- Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044), david . nalesnik, 2013/07/24
- Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044),
david . nalesnik <=