[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: astyle 2.02

From: Janek Warchoł
Subject: Re: astyle 2.02
Date: Mon, 30 Jun 2014 02:04:46 +0200

2014-06-29 6:10 GMT+02:00 Graham Percival <address@hidden>:
> The question to ask is where do you want the burden of producing
> properly formatted code?
> - a volunteer who runs manually once a year?
>   (this also produces "code reformatting" commits which disrupt
>   git blame)
> - an automated process which demands that the initial submitter
>   format the patch?
> - an automated process which demands that the pusher format the
>   patch?
>   (note that with new or casual committers, the pusher is not
>   the same as the committer)
> I favour the first or third option; people heavily involved in
> lilypond can set up a git hook and always have properly formatted
> code (whether they write the patch themselves or simply push
> somebody else's patch).  Asking casual committers to have a
> specific version of astyle seems like a high burden.

I was favoring 2nd option, but your arguments sound reasonable, so you
probably got me convinced to option 3.

2014-06-29 7:00 GMT+02:00 David Kastrup <address@hidden>:
> Janek Warchoł <address@hidden> writes:
>> I think we should enourage developers to use fixcc more often, and
>> then Graham's concern is very valid.  I can say that having to move
>> past 5 code reformattings when doing git blame is pretty annoying,
> git blame -w

silly me...  Thanks!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]