Re: Create engravers for merging rests (issue 321930043 by address@hidden)

[david . nalesnik]

https://codereview.appspot.com/321930043/diff/100001/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):

https://codereview.appspot.com/321930043/diff/100001/scm/scheme-engravers.scm#newcode167
scm/scheme-engravers.scm:167: (lambda (rest) (ly:grob-set-property! rest
'Y-offset (rest-offset rest)))
On 2017/05/21 04:27:33, horndude77 wrote:
> On 2017/05/20 14:33:15, david.nalesnik wrote:
> > Just moving one rest on top of the other might cause offsets with
some
> printers.
> >  This happened at one time with flags on chords: see
> > http://lists.gnu.org/archive/html/bug-lilypond/2015-08/msg00080.html
> >
> > Would it work to set 'stencil of all of the cdr to point-stencil?

> Using point-stencil causes odd alignment issues with text connected to
> multimeasure rests. Making them invisible doesn't have this issue.
Would that
> solve the above potential problem?

I'm not so sure now that I identified an actual problem, but this an
improvement b/c it will cut down on PDF file size.

> Related to this, is there a way to re-parent grobs onto the surviving
rest? If
> so we could then use point-stencil (or possibly fully destroy) the
other rests.

I'd have to look into this, but as a first observation I think it would
help if MultiMeasureRest stored pointers to associated
MultiMeasureRestText and MultiMeasureRestNumber grobs.  (This would be
done in the Multi_measure_rest_engraver.)

I don't think that this is something that needs to be tackled in this
patch.

https://codereview.appspot.com/321930043/