[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Calculate download sizes rather than hardcoding them (issue 567340043 by
From: |
lemzwerg |
Subject: |
Calculate download sizes rather than hardcoding them (issue 567340043 by address@hidden) |
Date: |
Thu, 05 Mar 2020 22:57:15 -0800 |
Very nice, thanks! From visual inspection, LGTM, with only minor nits.
https://codereview.appspot.com/567340043/diff/565730043/scripts/build/fix-docsize.sh
File scripts/build/fix-docsize.sh (right):
https://codereview.appspot.com/567340043/diff/565730043/scripts/build/fix-docsize.sh#newcode37
scripts/build/fix-docsize.sh:37: sed -n
's|^\./||;1h;1!H;${x;/\n/{s/^/{/;s/\n/,/g;s/$/}/};p}')" >&2
I think you can increase the readablity of the sed command if you use
more than a single line for the series of commands.
Additionally, according to the autoconf info manual, you shouldn't
combine '!' and ';' – I guess that modern sed implementations are not
affected, but...
https://codereview.appspot.com/567340043/diff/565730043/scripts/build/fix-docsize.sh#newcode50
scripts/build/fix-docsize.sh:50: sed 's/^[ ]*\([^ ]*\)[ ]*\([^ ]*\)[
]*$/\/<!-- file-size:\/s|<!--
file-size:\\([^>]*\\)href="\2"\\([^>]*\\)-->|\\1\1\\2|/')
What about putting the 's|...|...|' into a separate line?
https://codereview.appspot.com/567340043/
- Calculate download sizes rather than hardcoding them (issue 567340043 by address@hidden),
lemzwerg <=
- Re: Calculate download sizes rather than hardcoding them (issue 567340043 by address@hidden), jonas . hahnfeld, 2020/03/08
- Re: Calculate download sizes rather than hardcoding them (issue 567340043 by address@hidden), dak, 2020/03/08
- Re: Calculate download sizes rather than hardcoding them (issue 567340043 by address@hidden), jonas . hahnfeld, 2020/03/08
- Re: Calculate download sizes rather than hardcoding them (issue 567340043 by address@hidden), dak, 2020/03/08
- Re: Calculate download sizes rather than hardcoding them (issue 567340043 by address@hidden), jonas . hahnfeld, 2020/03/08