Re: xdvipdfmx fails with some regtests (“Invalid object”)

[David Kastrup]

Han-Wen Nienhuys <hanwenn@gmail.com> writes:

> On Fri, Jun 19, 2020 at 3:13 PM David Kastrup <dak@gnu.org> wrote:
>>
>> Han-Wen Nienhuys <hanwenn@gmail.com> writes:
>>
>> > On Fri, Jun 19, 2020 at 12:50 PM Jonas Hahnfeld <hahnjo@hahnjo.de> wrote:
>> >> No changes for me. Please also keep in mind that the same command
>> >> string works via the API interpreter. It could be that this is related
>> >> to processing other files before the "empty" one...
>> >> I'll try to write a small wrapper around the API so we can test outside
>> >> of LilyPond what actually triggers the broken PDF.
>> >
>> > Your hunch is correct. No need to write a wrapper, the following in a
>> > .ly file works if you replace SCM_UNDEFINED with SCM_UNSPECIFIED in
>> > ly:gs-api
>>
>> return SCM_UNDEFINED; is _NOT_ good behavior for Scheme functions.  I
>> have no idea why it is done here.
>
> Just an oversight I think. I missed it during review, as did you.

That would imply that I reviewed this patch.  At any rate, I just did a
fast (and likely not overly complete) grep through the code base
elsewhere, and there are several instances of code comparatively
recently written by me returning SCM_UNDEFINED from callbacks.  So it
would appear like my reading reflexes are not even sufficient for
self-review.

-- 
David Kastrup