Re: Note names inside dots

[Thomas Morley]

2015-10-24 23:20 GMT+02:00 Thomas Morley <address@hidden>:
> 2015-10-24 22:42 GMT+02:00 pls <address@hidden>:
>> Hi Harm,
>>
>> I just tested your changes (from 2014) to fret-diagram.scm and I really like 
>> the new
>> options.
>
> Glad you like it.
>
>> There is only one little issue: when one defines text inside dots
>> for open strings an unwanted capo bar appears. Tiny example:
>>
>> \version "2.19.30"
>>
>> \markup
>>   \override #'(size . 5)
>>   \override #'(fret-diagram-details . ((finger-code . in-dot)))
>>   \fill-line {
>>       \fret-diagram-verbose #`(
>>         (place-fret 4 0 "g")
>>       )
>>     }
>>
>> HTH,
>> Patrick
>
> Well, it's not related to my changes, as far as I can tell. See:
>
> \markup {
>       \fret-diagram-verbose #'(
>         (place-fret 4 0)
>       )
>     }
>
> I could follow this one bac to 2.14.2, the oldest I've installed atm
>
> Though, the syntax to enter an open string is `(open 4)', but with
> this you can't print text inside the dot. It is currently not
> supported.
> Nevertheless, I'd call the additional barre a bug.
>
> Please file a bug report, if none exists already (didn't check). I may
> have a look tomorrow (hopefully).
>
> Cheers,
>   Harm

Ok, I looked into it already.

It's this line in fret-diagrams.scm:
(set! capo-fret (1+ (- capo-fret minfret)))
Basically, if minfret and capo-fret are both zero, capo-fret is set 1.

This is present in 2.14.2 as well, I'll have to think about the reason
for it (and the consequences changing it)


Cheers,
  Harm