[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re[2]: [lmi] Code review: product editor

From: Vadim Zeitlin
Subject: Re[2]: [lmi] Code review: product editor
Date: Wed, 21 Mar 2007 18:44:56 +0100

On Wed, 21 Mar 2007 18:36:14 +0100 Evgeniy Tarassov <address@hidden> wrote:

ET> > The nice thing about this early return was that I could tell
ET> > immediately that this pointer wouldn't be dereferenced later if
ET> > it was NULL here. But maybe the early return was part of the
ET> > problem that needs to be solved.
ET> I removed it to deal with a potential "bug" in wx. I'm not sure that
ET> wxTreeCtrl guarantees that it will never select a root node when it is
ET> hidden.

 It does, of course. If the root is hidden, it can't be selected by the
user. So while the selection might become invalid (i.e. no selection at
all) it can't be a non-existing item.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]