[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [lwip-users] [PATCH 1/7] lwip: config sanity check for NETIP
From: |
Goldschmidt Simon |
Subject: |
RE: [lwip-users] [PATCH 1/7] lwip: config sanity check for NETIP |
Date: |
Mon, 24 Sep 2007 08:24:29 +0200 |
> Maybe this is a good candidate for a compiler specific fix: is #if
__GNUC__ acceptible in a lwip header?
In my opinion, not really! Can't that be solved by a more generic define
or something like that?
I'd imagine other comilers have that problem, too, which would end in
'#if A | B | C'...
I'm afraid I don't really understand the problem, I think, so correct me
if I'm wrong:
gcc4 gives an error 'return value not used' in pbuf.c:pbuf_realloc()
with MEM_LIBC_MALLOC=0?
Other solutions would be:
- removing the return value from mem_mrelloc()
- or really using the return value in pbuf.c so CLIB realloc() can be
used (even if we don't use it with our mem_realloc())
- '#define mem_realloc(x, size) (x) = realloc((x), (size))' so that x
is updated
Instead of 'wasting' memory on suchs targets...
Simon