Re: [Nano-devel] The undo feature

[Benno Schulenberg]

On Mon, Oct 27, 2014, at 20:55, Erik Lundin wrote:
> Mark Majeres wrote: 
> > Please look at do_wrap(), it shows how to use sub-undo's by only using
> > the existing undo structure.   Try to do all of the work in "tabs to
> > spaces" by using the do_delete() functions and wrapping the addition
> > of spaces with add_undo(ADD) and update_undo(ADD)
> 
> I've looked through the do_wrap() function and personally i think the
> whole undo function needs a remake. Retrofitting new code to fit the old
> code that never was designed to work that way seems wrong. For example,
> implementing a "undo step" function will be unnecessarily complicated
> with the current code.
> 
> But i understand that there's a lot of politics involved.

I don't think it's politics.  It's just about keeping any changes
as small as possible.  But if you want to rewrite a whole part
of the program, you are free to propose a patch.  (But if I can't
understand it I won't apply it.)

> Is Chris still
> the lead designer? What's your view on this Chris?

Let's try poking (CC'ing) Chris directly.

Benno

-- 
http://www.fastmail.fm - A fast, anti-spam email service.