[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] add rebinding for Ctrl+Arrow-keys combinations

From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] add rebinding for Ctrl+Arrow-keys combinations
Date: Sat, 27 Aug 2016 20:07:07 +0200

On Fri, Aug 26, 2016, at 15:17, Rishabh Dave wrote:
> Okay, first letters of up, down, right, left and space are capitalized in
> attached patch.

Okay.  Looks good.

> Oh! I completely forgot about editing the code for console. And didn't know
> enough to know the other change (relocating "s->keycode = keystring[1] -
> 64;")

The latter is just a tiny optimization, not important.

> So... translations are only for statusbar messages. How can I switch
> language in that case too?

Hmm.  Heard of search engines? Type for example this into duckduckgo:
  change language of terminal program
That should bring you close to an answer.  But to help you, run:
  LANGUAGE=fr src/nano
Choose for "fr" any other language that is available in po/.

> To check if all the code applies smoothly to master after pull, I did a
> checkout followed by pull and putting all code together (yours as well).

Apparently you're not letting git do the work for you.  When you
are trying to modify nano, it is best to work on a branch.  Commit
whatever you have so far, even when it's not working yet, on that
branch -- you can always change and improve that commit with:
  git commit --amend changedfile

When you then want to sync with upstream, you do:
  git checkout master
  git pull
  git checkout yourbranch
  git rebase master

If your changes still apply fine, the output will be short.  When
there are conflicts, it will be verbase and tells you what to do.

> and then I spent some time testing it. Attached is that patch.

Then properly commit it and create a signed-off patch, and
attach that to the relevant bug.

> However, I
> don't what next: most of the issue are solved except the translating few
> key in help.

That is a separate issue.

> About translating Home, End, PgUp and PgDn, for once I thought we can we
> use ⭰,  ⭲, ⭱, and ⭳ for Home, End. Pgup, Pgdn?

Huh?  I'm seeing narrow greyish smurfs there, all of them the same.
First: don't use HTML mail.  Second: try composing your email in nano
(where you are hopefully using a UTF-8 locale), then copy-and-paste it
to your mailer.  If the appearance changes, you know things are not right.

> We can also draw the buttons literally. They will be only 7 spaces wide but
> 3 line height.

Come on.  This is a terminal program.  That means: lines of text.  Not


-- - Accessible with your email software
                          or over the web

reply via email to

[Prev in Thread] Current Thread [Next in Thread]