Re: [Nano-devel] Nano with Line Numbering

[Faissal Bensefia]

On 12/09/16 09:52, Benno Schulenberg wrote:
> 
> On Sun, Sep 11, 2016, at 23:44, Faissal Bensefia wrote:
>> Ignore the last patch I sent, it had a mistake, this one fixes the
>> issues properly.
>> Now refreshes the whole page when line numbering is toggled,
> 
> Ehm... no, not for me.  You need to add a case in do_toggle()
> in src/nano.c.
> 
Oh, sorry about that, I've attached the proper fix.

>> and added
>> command line options for it (-l and --linenumbers). Attached.
> 
> Okay.  But... you didn't answer the question I asked in this email:
> https://lists.gnu.org/archive/html/nano-devel/2016-09/msg00017.html
> 
You must've missed it, I said:
>It fixes the issue where the last character wasn't appearing which you
said was incorrect behaviour.

> To see the effect of your "COLS + 1" change, run:
>    stty cols 80 && src/nano --linenum +5 NEWS
> and type A eight times.  See how a t appears before line number 6.
> 
I'm seeing no such issue, attached is a screenshot.

> (Attached is a tweaked patch, with some whitespace cleaned up
> and putting code after declarations.)
> 
> Benno
> 

~Faissal Bensefia

Screenshot_2016-09-12_11-46-17.png
Description: PNG image

0001-Added-line-numbering.patch
Description: Text Data