Re: [Nano-devel] Nano with Line Numbering

[Benno Schulenberg]

On Mon, Sep 12, 2016, at 13:01, Faissal Bensefia wrote:
> On 12/09/16 09:52, Benno Schulenberg wrote:
> > Ehm... no, not for me.  You need to add a case in do_toggle()
> > in src/nano.c.
> 
> Oh, sorry about that, I've attached the proper fix.

Thanks.  I've streamlined the fix.

> > Okay.  But... you didn't answer the question I asked in this email:
> > https://lists.gnu.org/archive/html/nano-devel/2016-09/msg00017.html
>
> You must've missed it, I said:
> > It fixes the issue where the last character wasn't appearing which you
> > said was incorrect behaviour.

I didn't miss that.  I know you fixed that bug.  But your fix
caused another bug.  Which I tried to show here:

> > To see the effect of your "COLS + 1" change, run:
> >    stty cols 80 && src/nano --linenum +5 NEWS
> > and type A eight times.  See how a t appears before line number 6.
>
> I'm seeing no such issue,

Okay.  Then let me be more precise.  Run this:
  stty cols 80 && src/nano --ignore --nowrap --linenum +5,22 NEWS

Then slowly type ten times an a.  See how from the second to
the ninth keystroke the characters from "ot much," appear before
line number 6, in reverse order.

Now hold down Shift and press the Right arrow until the cursor
reaches the end of the sentence.  See how "aces. " is not highlighted.
Now continue to the end of the line, and see how "t much," is not
highlighted.

Two bugs in your linenumbering patch that need fixing.

> attached is a screenshot.

Don't bother sending binary files.

By the way, what is NEWS.save doing in your diff?  Please inspect
your patches before sending them.

Benno

-- 
http://www.fastmail.com - IMAP accessible web-mail

0001-Working-toward-line-numbering-six.patch
Description: Text Data