Re: [Nano-devel] Nano with Line Numbering

[Faissal Bensefia]

On 13/10/16 20:09, Benno Schulenberg wrote:
> 
> On Thu, Oct 13, 2016, at 11:42, Faissal Bensefia wrote:
>> I've attached a new patch, I've removed the extra spacing and COLS -
>> margin is now calculated in two places, instead everywhere else uses the
>> variable editwincols so we aren't recalculating every time.
> 
> Good, thanks.  I think, though, that setting editwincols needs to
> be outside of the "#ifdef REDEFINING_MACROS_OK", and it should
Done.

> probably be initialized to COLS instead of to -1.
> 
That's not possible.
global.c:50:19: error: initializer element is not constant.

> Some more things could be wrapped in "#ifdef ENABLE_LINENUMBERS".
> The definition on intlen(), for example.  And the two last_ variables.
> 
>> I'll wait on
>> you to tell me what we're doing about the bar vs color vs nothing etc.
> 
> A version with the line-number bar in reverse video would be nice.
> 
> Benno
> 
Done.

~Faissal Bensefia

0001-Added-line-numbering.patch
Description: Text Data

0001-Added-line-numbering-A_REVERSE-style-ruler.patch
Description: Text Data