[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: nlinfit in octave

From: Asma Afzal
Subject: Re: nlinfit in octave
Date: Mon, 17 Aug 2015 20:52:13 +0100

Hi Olaf,

Thank you for the corrections.

> I've not completed the review, but AFAICS there is a fundamental
> misunderstanding in your nlinfit code: It's not considered that
> nonlin_residmin applies the specified weights as factors to the
> residuals, while Matlabs nlinfit seems to apply the specified weights
> to the squared residuals (i.e., applies the squareroot of the
> specified weights to the residuals).
> If you make a new revision, please also make this changes:
> - Don't state in the documentation 'using Iteratively Reweighted Least
>   Squares (IRLS) Method' because it's not true for our backend.
> -  if (nargs==6 || nargs > 7)
> +  if (nargs < 4 || nargs==6 || nargs > 7)
>      print_usage ();
>    endif
> - Check and correct code indentation.

I have made the changes in [1].

> Comparing them still shows differences:
> Within brackets, there must not be spaces between 'function name' and
> 'argument list in parantheses' (i.e. [exp (...)] does not work). This
> is what I meant when I criticized that you should run and check the
> code of your test blocks.

Sorry, I didn't update my repository with the latest version earlier.
Hopefully, it's updated now.

Kind Regards,

[1] https://github.com/AsmaAfzal/octave_workspace/blob/master/nlinfit.m

reply via email to

[Prev in Thread] Current Thread [Next in Thread]