Re: [Pan-users] ANN: Pan 0.94 "Ready! Fire! Aim!"

[Per Hedeland]

"Charles Kerr" <address@hidden> wrote:
>
>-  const int diff_secs (std::max (1l, now-_time_started));
>+  const int diff_secs (std::max ((time_t)1, now-_time_started));
>
>Smells like a more correct fix to me -- does it pass muster on BSD?

Yeah, that's fine too (though I think the "smell" is the only
conceivable difference:-).

>> Another thing which is also rather minor, though I find it annoying, is
>> that (at least compared to 0.14.2.91 that I was running before) the
>> lines in the group and header panes have a lot of empty space in between
>> them, which seriously limits the number of lines that fit in a window
>> (the body pane doesn't have this problem).
>
>Grumble, all right, since three people have asked for this now,
>I'll scrunch our the empty space for 0.95.

Yeah, my request tipped the scales!:-)

>  The trick is to set
>the "ypad" attribute to zero in the pane's cell renderers.

Hm, didn't work for me - I changed the only "ypad" that was in
pan/gui/header-pane.cc (date_renderer) from 1 to 0, and added "ypad" 0
to the other GTK_CELL_RENDERER calls - no difference. FYI, the lines are
16 pixels high (as needed for the icons) in my 0.14.2.91, and 20 in (my)
0.94 - I could have sworn that it was at least 50% more, but 25% is
significant too.:-) And I was actually wrong about chosing a smaller
font changing this, 20 is the minimum in 0.94, but a big enough font
will of course make the lines higher.

Hm, I see a patch for this was just posted - unfortunately that's
exactly the change I had done without effect. Is there something that
can make the old behavior "stick"...?:-)

--Per