[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/2] nbd: Add testsuite coverage

From: Jose E. Marchesi
Subject: Re: [PATCH v3 2/2] nbd: Add testsuite coverage
Date: Mon, 02 Mar 2020 20:01:17 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

    +Using NBD connections in tests
    +If your test requires an NBD server (only useful when poke is compiled
    +with libnbd), the dg-nbd directive is what you need.  It has one form::
    +  /* { dg-nbd { 0x1 0x2 ...} [dg-tmpdir]/sock } */
    +This utilizes nbdkit to serve an in-memory disk with initial contents
    +over a named Unix socket.  Note that the data argument is not written
    +in Poke, but rather the syntax accepted by nbdkit-data-plugin's data=

The syntax used in dg-data is not actually Poke.  It is the format
argument expected by the binary(3tcl) command.

Other than that, the patch is OK for master.
Thanks! :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]