[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/2] Add optional nbd:// io space support

From: Jose E. Marchesi
Subject: Re: [PATCH v3 1/2] Add optional nbd:// io space support
Date: Mon, 02 Mar 2020 20:15:21 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

    >            4  Coding Style and Conventions
    >              4.1  Writing C
    >              4.2  Writing Poke
    >              4.3  Writing RAS
    >            5  Writing Tests
    >      -       5.1  Naming Tests
    >      -       5.2  Always set obase
    >      -       5.3  Put each test in its own file
    >      -       5.4  dg-output may require a newline
    >      -       5.5  Using data files in tests
    >      -       5.6  Writing tests that depend on a certain capability
    >      +       5.1  Test framework
    Pre-existing bug for a section that was added without updating toc
    (no, I didn't check git history for when),

Heh 100% it was me :)
    > Isn't the hunk for the table of contents a bit weird?  You are just
    > adding a new section.  Maybe the emacs rst-toc-update went banana?
    > (it doesn't work that well :/).
    rst-toc-update tried to touch even more than what I included here: it
    tried to convert between spaces and tabs, and touched even more
    lines. I already pruned it down manually to the maximum that I was
    comfortable having it touch, but it does mean that my next run of
    rst-toc-update will also botch things.  I'm not sure how to improve
    the situation.

We could maybe keep the table of contents, without section numbers, and
maintain it manually.  Section numbers in the TOC are sort of silly,
since the section headers do not feature them anyway.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]