Re: [PATCH v3 1/2] Add optional nbd:// io space support

[Eric Blake]

On 3/2/20 1:05 PM, Jose E. Marchesi wrote:
>      diff --git a/HACKING b/HACKING
>      index ed8f46ab..2a62a8ec 100644
>      --- a/HACKING
>      +++ b/HACKING
>      @@ -44,22 +44,24 @@ along with GNU poke.  If not, see 
> <https://www.gnu.org/licenses/>.
>              3. 5  Boehm GC
>              3. 6  Jitter
>              3. 7  libtextstyle
>      -       3. 8  Building
>      -       3. 9  Building a 32-bit poke
>      -       3.10  Gettext
>      -       3.11  Running an Uninstalled Poke
>      -       3.12  Continuous Integration
>      +       3. 8  libnbd

New section,

>      +       3. 9  Building
>      +       3.10  Building a 32-bit poke
>      +       3.11  Gettext
>      +       3.12  Running an Uninstalled Poke
>      +       3.13  Continuous Integration

Renumbering,

>            4  Coding Style and Conventions
>              4.1  Writing C
>              4.2  Writing Poke
>              4.3  Writing RAS
>            5  Writing Tests
>      -       5.1  Naming Tests
>      -       5.2  Always set obase
>      -       5.3  Put each test in its own file
>      -       5.4  dg-output may require a newline
>      -       5.5  Using data files in tests
>      -       5.6  Writing tests that depend on a certain capability
>      +       5.1  Test framework

Pre-existing bug for a section that was added without updating toc (no, 
I didn't check git history for when),

>      +       5.2  Naming Tests
>      +       5.3  Always set obase
>      +       5.4  Put each test in its own file
>      +       5.5  dg-output may require a newline
>      +       5.6  Using data files in tests
>      +       5.7  Writing tests that depend on a certain capability

and more renumbering.

> Isn't the hunk for the table of contents a bit weird?  You are just
> adding a new section.  Maybe the emacs rst-toc-update went banana?
> (it doesn't work that well :/).

rst-toc-update tried to touch even more than what I included here: it 
tried to convert between spaces and tabs, and touched even more lines. 
I already pruned it down manually to the maximum that I was comfortable 
having it touch, but it does mean that my next run of rst-toc-update 
will also botch things.  I'm not sure how to improve the situation.

>      
> Other than that this looks super!
> OK for master.
>
> Thanks!

Okay, will push things shortly.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org