qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 08/60] target/arm: Change DisasContext.thumb to bool


From: Richard Henderson
Subject: Re: [PATCH v3 08/60] target/arm: Change DisasContext.thumb to bool
Date: Fri, 22 Apr 2022 08:24:08 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0

On 4/22/22 07:04, Peter Maydell wrote:
On Fri, 22 Apr 2022 at 15:01, Alex Bennée <alex.bennee@linaro.org> wrote:


Richard Henderson <richard.henderson@linaro.org> writes:

Bool is a more appropriate type for this value.
Move the member down in the struct to keep the
bool type members together and remove a hole.

Does gcc even attempt to pack bools? Aren't they basically int types?

It's impdef, I think, but it'll typically be a 1 byte integer
rather than a 4 byte integer, with the usual struct packing
rules for 1 byte type sizes.

Yep, it's 1 byte for all extant abis except macos where it's 4.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]