[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 06/27] qcow2: Use QCryptoBlockCreateOptions in q

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 06/27] qcow2: Use QCryptoBlockCreateOptions in qcow2_create2()
Date: Fri, 9 Feb 2018 08:13:21 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 02/08/2018 01:23 PM, Kevin Wolf wrote:
Instead of passing the encryption format name and the QemuOpts down, use
the QCryptoBlockCreateOptions contained in BlockdevCreateOptions.

Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
  block/qcow2.c | 62 +++++++++++++++++++++++++++++++++++++++++++----------------
  1 file changed, 45 insertions(+), 17 deletions(-)

@@ -3010,6 +3026,7 @@ static int qcow2_create(const char *filename, QemuOpts 
*opts, Error **errp)
          ret = -EINVAL;
          goto finish;
      encryptfmt = qemu_opt_get_del(opts, BLOCK_OPT_ENCRYPT_FORMAT);
      if (encryptfmt) {
          if (qemu_opt_get(opts, BLOCK_OPT_ENCRYPT)) {

Should this whitespace change belong to a different patch?

R-b still stands

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]