[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 08/27] util: Add qemu_opts_to_qdict_filtered()

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 08/27] util: Add qemu_opts_to_qdict_filtered()
Date: Thu, 15 Feb 2018 13:33:57 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 02/08/2018 01:23 PM, Kevin Wolf wrote:
This allows, given a QemuOpts for a QemuOptsList that was merged from
multiple QemuOptsList, to only consider those options that exist in one
specific list. Block drivers need this to separate format-layer create
options from protocol-level options.

Signed-off-by: Kevin Wolf <address@hidden>
  include/qemu/option.h |  2 ++
  util/qemu-option.c    | 37 ++++++++++++++++++++++++++++++++-----
  2 files changed, 34 insertions(+), 5 deletions(-)

Is there any unit test coverage we should be adding, beyond the default we get when the list parameter is NULL?

But what you have looks sane;
Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]