Re: [PATCH v3 7/9] hw/ppc/e500: Implement pflash handling

[BALATON Zoltan]

On Tue, 18 Oct 2022, Bin Meng wrote:
> On Tue, Oct 18, 2022 at 3:46 PM Bernhard Beschow <shentey@gmail.com> wrote:
> > Am 16. Oktober 2022 14:15:09 UTC schrieb BALATON Zoltan <balaton@eik.bme.hu>:
> > > On Sun, 16 Oct 2022, Bernhard Beschow wrote:
> > > > Allows e500 boards to have their root file system reside on flash using
> > > > only builtin devices located in the eLBC memory region.
> > > >
> > > > Note that the flash memory area is only created when a -pflash argument is
> > > > given, and that the size is determined by the given file. The idea is to
> > > > put users into control.
> > > >
> > > > Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> > > > ---
> > > > docs/system/ppc/ppce500.rst | 16 ++++++++++
> > > > hw/ppc/Kconfig              |  1 +
> > > > hw/ppc/e500.c               | 62 +++++++++++++++++++++++++++++++++++++
> > > > 3 files changed, 79 insertions(+)
> > > >
> > > > diff --git a/docs/system/ppc/ppce500.rst b/docs/system/ppc/ppce500.rst
> > > > index ba6bcb7314..99d2c680d6 100644
> > > > --- a/docs/system/ppc/ppce500.rst
> > > > +++ b/docs/system/ppc/ppce500.rst
> > > > @@ -165,3 +165,19 @@ if “-device eTSEC” is given to QEMU:
> > > > .. code-block:: bash
> > > >
> > > >   -netdev tap,ifname=tap0,script=no,downscript=no,id=net0 -device 
> > > > eTSEC,netdev=net0
> > > > +
> > > > +Root file system on flash drive
> > > > +-------------------------------
> > > > +
> > > > +Rather than using a root file system on ram disk, it is possible to have it on
> > > > +CFI flash. Given an ext2 image whose size must be a power of two, it can be 
> > > > used
> > > > +as follows:
> > > > +
> > > > +.. code-block:: bash
> > > > +
> > > > +  $ qemu-system-ppc{64|32} -M ppce500 -cpu e500mc -smp 4 -m 2G \
> > >
> > > We have qemu-system-ppc and qemu-system-ppc64 not qemu-system-ppc32 so maybe 
> > > qemu-system-ppc[64] even though that looks odd so maybe just qemu-system-ppc 
> > > and then people should know that ppc64 includes ppc config as well.
> >
> > True. This naming is used elsewhere in this document, so we kept it consistent. 
> > I think that users will get it either way.
> >
> > @Bin: Any thoughts?
>
> How about a separate patch to remove the {64 | 32} suffix, and just
> use qemu-system-ppc64 consistently since the *ppc64 executable can run
> 32-bit ppc codes too?

In case it's already there then yes it's unrelated to this series so just 
disregard my comment or add a separate patch to fix it if you can. I did 
not check the rest of the doc just noticed this in this patch.

Regards,
BALATON Zoltan