[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] avoid name clashes due to LIST_* macros

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] avoid name clashes due to LIST_* macros
Date: Wed, 06 Feb 2008 13:14:43 -0600
User-agent: Thunderbird (X11/20071229)

Ian Jackson wrote:
qemu's audio subdirectory contains a copy of BSD's sys-queue.h, which
defines a bunch of LIST_ macros.  This makes it difficult to build a
program made partly out of qemu and partly out of the Linux kernel[1],
since Linux has a different set of LIST_ macros.  It might also cause
trouble when mixing with BSD-derived code.

That doesn't seem like a very good justification. If you're mixing QEMU code with other code, it's easier for you to maintain these merge conflict fixes as normal QEMU developers would have no idea what it wasn't okay to just use LIST_xxx


Anthony Liguori

Under the circumstances it's probably best to rename the versions in
qemu.  The attached patch does this.

[1] You might well ask why anyone would want to do this.  In Xen we
are moving our emulation of IO devices from processes which run on the
host into a dedicated VM (one per actual VM) which we call a `stub
domain'.  This dedicated VM runs a very cut-down `operating system'
which uses some code from Linux.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]