[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] tcg-hppa: Finish the port.
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] tcg-hppa: Finish the port. |
Date: |
Tue, 23 Mar 2010 22:28:36 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, Mar 17, 2010 at 07:56:12AM -0700, Richard Henderson wrote:
> On 03/16/2010 06:58 PM, Stuart Brady wrote:
> > The tcg_reg_free() calls worry me slightly, but I assume they're safe...
>
> Yeah, that one's rather gross.
>
> Since Aurelien's generic div/rem patch I could simply remove all
> that millicode stuff, including that tcg_reg_free, and let the
> generic code handle this instead. Which would get to the same
> millicode routine via one or two extra levels of indirection.
>
> Thoughts?
>
I think that's the way to go. Can you please send a new patch doing
that?
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net