Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

[Anthony Liguori]

On 03/09/2011 07:28 AM, Avi Kivity wrote:
> On 03/07/2011 03:41 PM, Anthony Liguori wrote:
> > On 03/07/2011 07:35 AM, Stefan Hajnoczi wrote:
> > > On Mon, Mar 7, 2011 at 1:22 AM, Anthony 
> > > Liguori<address@hidden>  wrote:
> > > > diff --git a/qmp-schema.json b/qmp-schema.json
> > > > index e69de29..b343f5e 100644
> > > > --- a/qmp-schema.json
> > > > +++ b/qmp-schema.json
> > > > @@ -0,0 +1,38 @@
> > > > +# *-*- Mode: Python -*-*
> > > By the way JSON does not seem to support comments (neither /* */ nor
> > > #).  So this comment feature you're using is an extension to JSON.
> >
> > Yeah, it's only loosely JSON as I don't use a JSON parser.
>
> Goes kind of against all the buzzwords you're letting fly here...

The schema defines arguments in a dictionary because in QMP, the 
argument order doesn't matter.  But the argument order matters in C so I 
need to use a custom parser to preserve dictionary order.

There's no way to do commenting in JSON and I really wanted to have 
inline documentation.

But otherwise, it's valid JSON.

Regards,

Anthony Liguori