Re: [Qemu-devel] [PATCH 21/26] Implement TCE translation for sPAPR VIO

[David Gibson]

On Wed, Mar 16, 2011 at 05:20:53PM -0500, Anthony Liguori wrote:
> On 03/15/2011 11:56 PM, David Gibson wrote:
> >From: Ben Herrenschmidt<address@hidden>
[snip]
> >+static target_ulong h_put_tce(CPUState *env, sPAPREnvironment *spapr,
> >+                              target_ulong opcode, target_ulong *args)
> >+{
> >+    target_ulong liobn = args[0];
> >+    target_ulong ioba = args[1];
> >+    target_ulong tce = args[2];
> >+    VIOsPAPRDevice *dev = spapr_vio_find_by_reg(spapr->vio_bus, liobn);
> >+    VIOsPAPR_RTCE *rtce;
> >+
> >+    if (!dev) {
> >+        fprintf(stderr, "spapr_vio_put_tce on non-existent LIOBN "
> >+                TARGET_FMT_lx "\n",
> >+                liobn);
> 
> You generally want to avoid guest triggered fprintfs as it can be
> exploited in scenarios where qemu's stdout is logged to disk
> (libvirt).  We usually wrap this in a DPRINTF() of some sort.

Ah, good point.  I've gone through and audited for this sort of thing.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson